Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update napalm agent dependencies and add overflow integer check #15

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feat: update napalm agent dependencies and add overflow integer check #15

merged 2 commits into from
Oct 17, 2024

Conversation

leoparente
Copy link
Collaborator

This PR addresses: netboxlabs/diode#187

  • Allow dependencies change for minor patches avoiding major
  • Proper convert napalm interface speed (MBps) to diode/netbox expected speed (Kbps)
  • Add overflow check and ignore it if it happens

@leoparente leoparente self-assigned this Oct 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
diode_napalm
   discovery.py36294%93–96
   parser.py55198%114
   version.py7186%14
diode_napalm/cli
   cli.py60198%164
TOTAL237598% 

Tests Skipped Failures Errors Time
37 0 💤 0 ❌ 0 🔥 1.617s ⏱️

mfiedorowicz
mfiedorowicz approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@leoparente leoparente merged commit c58b91a into develop Oct 17, 2024
8 checks passed
@leoparente leoparente deleted the feat/update-dependencies-and-if-speed-check branch October 17, 2024 13:08
@leoparente leoparente mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@natm natm Awaiting requested review from natm natm is a code owner

Assignees

@leoparente leoparente

Labels
dependencies markdown python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leoparente @mfiedorowicz